flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink
Date Tue, 14 May 2019 07:24:04 GMT
wuchong commented on a change in pull request #8435: [FLINK-12443][table-planner-blink] Replace
InternalType with LogicalType in blink
URL: https://github.com/apache/flink/pull/8435#discussion_r283657779
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/functions/aggfunctions/RankLikeAggFunctionBase.java
 ##########
 @@ -98,30 +108,30 @@ protected Expression orderKeyEqualsExpression() {
 		return ret.orElseGet(() -> literal(true));
 	}
 
-	protected Expression generateInitLiteral(InternalType orderType) {
-		if (orderType.equals(InternalTypes.BOOLEAN)) {
+	protected Expression generateInitLiteral(LogicalType orderType) {
+		if (orderType instanceof BooleanType) {
 
 Review comment:
   Agree, `InternalType` is more similar to `LogicalTypeRoot`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message