flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #8430: [FLINK-12068] [runtime] Backtrack failover regions if intermediate results are unavailable
Date Wed, 15 May 2019 11:32:04 GMT
zentol commented on a change in pull request #8430: [FLINK-12068] [runtime] Backtrack failover
regions if intermediate results are unavailable
URL: https://github.com/apache/flink/pull/8430#discussion_r284197706
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/RestartPipelinedRegionStrategy.java
 ##########
 @@ -57,7 +66,9 @@
 	 */
 	public RestartPipelinedRegionStrategy(FailoverTopology topology) {
 		this.topology = checkNotNull(topology);
-		this.regions = new HashMap<>();
+		this.regions = new IdentityHashMap<>();
+		this.vertexToRegionMap = new HashMap<>();
+		this.resultPartitionAvailabilityChecker = new RegionFailoverResultPartitionAvailabilityChecker();
 
 Review comment:
   I would change this setup a bit.
   
   Add a `ResultPartitionAvailabilityChecker` constructor argument, which is then wrapped
internally with a `RegionFailoverResultPartitionAvailabilityChecker`.
   The wrapper handles the partitions that were determined _by the strategy_ to be unavailable,
but otherwise defers to the backing checker.
   
   This allows us to test scenarios where certain partitions are still available.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message