flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] 1u0 opened a new pull request #8451: [FLINK-12513][e2e] Improve end-to-end (bash based) tests
Date Wed, 15 May 2019 12:56:35 GMT
1u0 opened a new pull request #8451: [FLINK-12513][e2e] Improve end-to-end (bash based) tests
URL: https://github.com/apache/flink/pull/8451
 
 
   ## What is the purpose of the change
   
   Make bash based end-to-end tests more "isolated" from each other (by more thorough clean
up).
   
   ## Brief change log
   
     - whole Flink `lib` and `conf` sub directories are backed up and restored on each test
run by `test-runner-common.sh`. Tests themselves don't need to revert their changes for this
dirs anymore.
     - introduced an `on_exit` hook as alternative to built-in `trap` hook. The letter is
discouraged to be used directly in tests.
     - refactored Flink config key delete and setter methods.
   
   
   ## Verifying this change
   
    - Would be nice to run this changes in CI environment and see if there are any test failures.
     - Some new methods and their behavior was tested manually by running a sample test:
   ```bash
   #!/usr/bin/env bash
   
   source "$(dirname "$0")"/common.sh
   
   # Check on_exit hook
   function foo {
       echo "Debug 1"
       ls -la "$FLINK_DIR/lib/"
   }
   
   function foo_2 {
       echo "Debug 2"
       ls -la "$FLINK_DIR/lib/"
   }
   
   on_exit foo
   on_exit foo_2
   
   # Check add_optional_lib
   
   add_optional_lib "table"
   add_optional_lib "s3-fs-presto"
   
   ls -lh "$FLINK_DIR/lib"
   
   # Check config_key methods
   
   set_config_key "jobmanager.archive.fs.dir" "hdfs:///sdsds-jobs/"
   set_config_key parallelism.default 42
   delete_config_key high-availability
   delete_config_key jobmanager.rpc.address
   cp ${FLINK_DIR}/conf/flink-conf.yaml ${FLINK_DIR}/conf/flink-conf.test.yaml
   ```
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message