flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment
Date Fri, 17 May 2019 08:32:30 GMT
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate
setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r285026330
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/PartitionTestUtils.java
 ##########
 @@ -40,35 +38,38 @@ public static ResultPartition createPartition(ResultPartitionType type)
{
 				false);
 	}
 
-	public static ResultPartition createPartition(ResultPartitionType type, int numChannels)
{
-		return createPartition(new NoOpResultPartitionConsumableNotifier(), type, numChannels,
false);
-	}
-
 	public static ResultPartition createPartition(
 			ResultPartitionConsumableNotifier notifier,
 			ResultPartitionType type,
 			boolean sendScheduleOrUpdateConsumersMessage) {
 
-		return createPartition(notifier, type, 1, sendScheduleOrUpdateConsumersMessage);
+		return createPartition(null, notifier, type, 1, sendScheduleOrUpdateConsumersMessage);
 	}
 
 	public static ResultPartition createPartition(
 
 Review comment:
   Since we already have the `ResultPartitionBuilder`, this `PartitionTestUtils` seems not
very necessary because it seems trouble to maintain the different units of parameters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message