flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hxbks2ks commented on a change in pull request #8472: [FLINK-12327][python] Adds support to submit Python Table API job in CliFrontend
Date Fri, 17 May 2019 15:14:38 GMT
hxbks2ks commented on a change in pull request #8472: [FLINK-12327][python] Adds support to
submit Python Table API job in CliFrontend
URL: https://github.com/apache/flink/pull/8472#discussion_r285170191
 
 

 ##########
 File path: flink-clients/src/main/java/org/apache/flink/client/cli/ProgramOptions.java
 ##########
 @@ -62,21 +65,68 @@
 
 	private final SavepointRestoreSettings savepointSettings;
 
+	// Store whether the job is python.
+	private boolean isPython = false;
+
 	protected ProgramOptions(CommandLine line) throws CliArgsException {
 		super(line);
 
 		String[] args = line.hasOption(ARGS_OPTION.getOpt()) ?
-				line.getOptionValues(ARGS_OPTION.getOpt()) :
-				line.getArgs();
+			line.getOptionValues(ARGS_OPTION.getOpt()) :
+			line.getArgs();
+
+		// If specified the option -py(--python)
+		if (line.hasOption(PY_OPTION.getLongOpt())) {
 
 Review comment:
   The method hasOption will call a method resolveOption which will consider both short option
and longOption.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message