flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation.
Date Fri, 17 May 2019 15:24:16 GMT
wuchong commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support
translation from StreamExecGroupWindowAggregate to StreamTransformation.
URL: https://github.com/apache/flink/pull/8462#discussion_r285172572
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/util/WindowEmitStrategy.scala
 ##########
 @@ -115,7 +115,10 @@ class WindowEmitStrategy(
 
 object WindowEmitStrategy {
   def apply(tableConfig: TableConfig, window: LogicalWindow): WindowEmitStrategy = {
-    val isEventTime = window.timeAttribute.getResultType == TimeIndicatorTypeInfo.ROWTIME_INDICATOR
+    val isEventTime = window.timeAttribute.getResultType match {
 
 Review comment:
   Can we replace this with `isRowtimeIndicatorType` util function here? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message