flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] AjaxXu commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler non-blocking
Date Fri, 17 May 2019 16:09:49 GMT
AjaxXu commented on a change in pull request #8467: [FLINK-12535][network] Make CheckpointBarrierHandler
non-blocking
URL: https://github.com/apache/flink/pull/8467#discussion_r285191329
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/InputGate.java
 ##########
 @@ -78,32 +79,32 @@
 
 	public abstract String getOwningTaskName();
 
-	public abstract boolean isFinished();
-
 	public abstract void requestPartitions() throws IOException, InterruptedException;
 
 	/**
 	 * Blocking call waiting for next {@link BufferOrEvent}.
 	 *
 	 * @return {@code Optional.empty()} if {@link #isFinished()} returns true.
 	 */
-	public abstract Optional<BufferOrEvent> getNextBufferOrEvent() throws IOException,
InterruptedException;
+	public abstract Optional<BufferOrEvent> getNext() throws IOException, InterruptedException;
 
 Review comment:
   Even through get a buffer or event without blocking, it still can be named with getNextBufferOrEvent().
What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message