flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #8429: [FLINK-12499][JDBC] JDBCAppendTableSink support retry
Date Sat, 18 May 2019 03:41:08 GMT
hequn8128 commented on a change in pull request #8429: [FLINK-12499][JDBC] JDBCAppendTableSink
support retry
URL: https://github.com/apache/flink/pull/8429#discussion_r285117654
 
 

 ##########
 File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
 ##########
 @@ -41,6 +46,8 @@
 public class JDBCOutputFormat extends RichOutputFormat<Row> {
 	private static final long serialVersionUID = 1L;
 	static final int DEFAULT_BATCH_INTERVAL = 5000;
+	static final int DEFAULT_RETIES = 0;
+	static final Time DEFAULT_RETRY_DELAY = Time.milliseconds(0);
 
 Review comment:
   Maybe it's not good to make the default delay time 0. It's easy to bring big pressure to
the database. Give it a value, say Time.milliseconds(100). What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message