flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] felse opened a new pull request #8478: [FLINK-12550] fix local input split assignment for hostnames containing a dot (".")
Date Sat, 18 May 2019 17:57:32 GMT
felse opened a new pull request #8478: [FLINK-12550] fix local input split assignment for hostnames
containing a dot (".")
URL: https://github.com/apache/flink/pull/8478
 
 
   ## What is the purpose of the change
   LocatableInputSplitAssigner does not assign input splits locally if the hostname contains
a dot ("."), like in hostname.domain. This PR should fix this issue.
   
   ## Brief change log
   The hostnames of the input split locations are now prepared in the same way as the hostname
of the TaskManager that is getting the next input split, before they are compared to each
other.
   
   ## Verifying this change
   A unit test has been added (testLocalSplitAssignmentForHostWithDomainName in LocatableSplitAssignerTest).
This test fails with all previous versions of LocatableInputSplitAssigner and passes with
the change introcuced in this PR.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message