flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog and GenericHiveMetastoreCat…
Date Mon, 20 May 2019 00:48:07 GMT
bowenli86 commented on a change in pull request #8480: [FLINK-12552][table]: Combine HiveCatalog
and GenericHiveMetastoreCat…
URL: https://github.com/apache/flink/pull/8480#discussion_r285405982
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCatalog.java
 ##########
 @@ -48,6 +48,9 @@
  * A generic catalog implementation that holds all meta objects in memory.
  */
 public class GenericInMemoryCatalog implements Catalog {
+	public static final String FLINK_META_PROPERTY_KEY = "is_generic";
 
 Review comment:
   seems duplicate to HiveCatalog.GENERIC_META_PROPERTY_KEY. 
   
   We can either use 'is_generic' and `mask/retrieveFlinkProperties()` to deal with the `flink.`
prefix, or just use 'flink.is_generic' after/before calls to `mask/retrieveFlinkProperties()`.
Either way, we need to be consistent 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message