flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] beyond1920 commented on a change in pull request #8462: [FLINK-12496][table-planner-blink] Support translation from StreamExecGroupWindowAggregate to StreamTransformation.
Date Tue, 21 May 2019 03:42:03 GMT
beyond1920 commented on a change in pull request #8462: [FLINK-12496][table-planner-blink]
Support translation from StreamExecGroupWindowAggregate to StreamTransformation.
URL: https://github.com/apache/flink/pull/8462#discussion_r285840399
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java
 ##########
 @@ -309,6 +309,28 @@ public static SimpleDateFormat newDateFormat(String format) {
 		return sdf;
 	}
 
+	/** Helper for CAST({timestamp} Or {date} or {time} AS VARCHAR(n)). */
+	public static String unixDateTimeToString(Object o, TimeZone tz) {
 
 Review comment:
   Sure, I will move the method to `TestSinkUtil`.
   But almost all method in `DateTimeUtils` are copied from Calcite……

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message