flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #8494: [FLINK-12570] Switch Task from ResultPartition to ResultPartitionWriter interface
Date Tue, 21 May 2019 11:09:04 GMT
zhijiangW commented on a change in pull request #8494: [FLINK-12570] Switch Task from ResultPartition
to ResultPartitionWriter interface
URL: https://github.com/apache/flink/pull/8494#discussion_r285970393
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
 ##########
 @@ -510,6 +512,14 @@ public void flushAll() {
 		public void flush(int subpartitionIndex) {
 		}
 
+		@Override
+		public void fail(@Nullable Throwable throwable) {
 
 Review comment:
   Why not keep the same way of `UnsupportedOperationException` as others?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message