flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] godfreyhe commented on a change in pull request #8460: [FLINK-12524] [table-planner-blink] Introduce planner rules about rank
Date Tue, 21 May 2019 13:51:10 GMT
godfreyhe commented on a change in pull request #8460: [FLINK-12524] [table-planner-blink]
Introduce planner rules about rank
URL: https://github.com/apache/flink/pull/8460#discussion_r286035658
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/plan/rules/logical/RankNumberColumnRemoveRuleTest.scala
 ##########
 @@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.rules.logical
+
+import org.apache.flink.api.scala._
+import org.apache.flink.table.plan.optimize.program.FlinkStreamProgram
+import org.apache.flink.table.util.TableTestBase
+
+import org.junit.{Before, Test}
+
+/**
+  * Test for [[RankNumberColumnRemoveRule]].
+  */
+class RankNumberColumnRemoveRuleTest extends TableTestBase {
+  private val util = streamTestUtil()
+
+  @Before
+  def setup(): Unit = {
+    util.buildStreamProgram(FlinkStreamProgram.PHYSICAL)
+
+    util.addDataStream[(Int, String, Long)]("MyTable", 'a, 'b, 'c, 'rowtime)
+  }
+
+  @Test
+  def testCannotRemoveRankNumberColumn1(): Unit = {
+    val sql =
+      """
+        |SELECT a, rank_num FROM (
+        |  SELECT *,
+        |      RANK() OVER (PARTITION BY a ORDER BY rowtime DESC) as rank_num
+        |  FROM MyTable)
+        |WHERE rank_num >= 1 AND rank_num < 2
+      """.stripMargin
+
+    util.verifyPlan(sql)
+  }
+
+  @Test
+  def testCannotRemoveRankNumberColumn2(): Unit = {
+    val sql =
+      """
+        |SELECT a, rank_num FROM (
+        |  SELECT *,
+        |      ROW_NUMBER() OVER (PARTITION BY a ORDER BY rowtime DESC) as rank_num
+        |  FROM MyTable)
+        |WHERE rank_num >= 1 AND rank_num < 3
+      """.stripMargin
+
+    util.verifyPlan(sql)
+  }
+
+  @Test
+  def testCannotRemoveRankNumberColumn3(): Unit = {
 
 Review comment:
   the original Rank does not output row number, so RankNumberColumnRemoveRule will not be
matched(it requires `isRowNumber && constantRowNumber && rank.outputRankNumber`
is true)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message