flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] twalthr commented on a change in pull request #8497: [FLINK-12566][table] Remove row interval type
Date Tue, 21 May 2019 14:02:38 GMT
twalthr commented on a change in pull request #8497: [FLINK-12566][table] Remove row interval
type
URL: https://github.com/apache/flink/pull/8497#discussion_r286041785
 
 

 ##########
 File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/expressions/literals.scala
 ##########
 @@ -60,7 +60,6 @@ case class Literal(value: Any, resultType: TypeInformation[_]) extends
LeafExpre
     case _@SqlTimeTypeInfo.TIMESTAMP => value.toString + ".toTimestamp"
     case _@TimeIntervalTypeInfo.INTERVAL_MILLIS => value.toString + ".millis"
     case _@TimeIntervalTypeInfo.INTERVAL_MONTHS => value.toString + ".months"
-    case _@RowIntervalTypeInfo.INTERVAL_ROWS => value.toString + ".rows"
 
 Review comment:
   The suffix expression `.rows` is still valid for expressions. But since the type does not
exist anymore, this string can not be generated anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message