flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] eaglewatcherwb commented on a change in pull request #8498: [FLINK-12413] [runtime] Implement ExecutionFailureHandler
Date Thu, 23 May 2019 11:50:40 GMT
eaglewatcherwb commented on a change in pull request #8498: [FLINK-12413] [runtime] Implement
ExecutionFailureHandler
URL: https://github.com/apache/flink/pull/8498#discussion_r286898461
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailoverStrategy.java
 ##########
 @@ -34,4 +34,22 @@
 	 * @return set of IDs of vertices to restart
 	 */
 	Set<ExecutionVertexID> getTasksNeedingRestart(ExecutionVertexID executionVertexId,
Throwable cause);
+
+	// ------------------------------------------------------------------------
+	//  factory
+	// ------------------------------------------------------------------------
 
 Review comment:
   position marker is not a good choice (see Clean Code by Robert C Martin, page 67, Chapter
4).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message