flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] rmetzger commented on issue #8464: [hotfix] fix typos.
Date Thu, 23 May 2019 11:59:53 GMT
rmetzger commented on issue #8464: [hotfix] fix typos.
URL: https://github.com/apache/flink/pull/8464#issuecomment-495188310
 
 
   Hey, I'm happy to answer your question:
   The community is very busy reviewing pull requests, discussing JIRA tickets, working on
designs or implementing features for Flink. Thus committers prioritize their time. 
   I can not speak for others, but for me, this pull request doesn't get a very high priority.
   It does not solve a problem, or substantially improve Flink: These typo's are just in the
comments, and everybody will figure out what the intention of the original author was.
   To me, it seems that you've opened this pull request just for the sake of opening a pull
request, not for improving Flink, but for being able to claim having made a contribution.
For us committers, we probably spend more time checking and merging your change, than others
would spend autocorrecting the comments when reading the code.
   
   I will merge this change now (because I have spend a lot of time on it already), but if
you want to contribute to Flink, I would recommend to focus on other things. For example,
we have currently 445 open pull requests.
   You could help reviewing some pull requests. For example these need a code review: https://github.com/apache/flink/pulls?q=is%3Aopen+is%3Apr+label%3Areview%3Dquality%3F
   There are some more ideas how to contribute here: https://www.slideshare.net/robertmetzger1/how-to-contribute-to-apache-flink-and-flink-at-the-apache-software-foundation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message