flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API
Date Thu, 23 May 2019 12:46:44 GMT
zentol commented on a change in pull request #8485: [FLINK-12555] Introduce an encapsulated
metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r286914398
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -388,10 +378,12 @@ public Task(
 			this,
 			inputGateDeploymentDescriptors,
 			metrics.getIOMetricGroup(),
-			inputGroup,
-			buffersGroup,
 			metrics.getIOMetricGroup().getNumBytesInCounter());
 
+		// we will have to check type of shuffle service later whether it is NetworkEnvironment
+		//noinspection deprecation
 
 Review comment:
   inconsistent with other parts of the PR that use `@SuppressWarnings("deprecation")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message