flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] pnowojski commented on a change in pull request #8476: [FLINK-12490][network] Introduce Input and NetworkInput interfaces
Date Thu, 23 May 2019 13:19:33 GMT
pnowojski commented on a change in pull request #8476: [FLINK-12490][network] Introduce Input
and NetworkInput interfaces
URL: https://github.com/apache/flink/pull/8476#discussion_r286937831

 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/Input.java
 @@ -0,0 +1,31 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.streaming.runtime.io;
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.runtime.io.AsyncDataInput;
+import org.apache.flink.streaming.runtime.streamrecord.StreamElement;
+import java.io.Closeable;
+ * Basic interface for inputs of stream operators.
+ */
+public interface Input extends AsyncDataInput<StreamElement>, Closeable {
 Review comment:
   @sunhaibotb, are you fine with renaming those renames? (and fyi, since renaming will affect
a wip `StreamSelectableTwoInputStreamProcessor` PR.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message