flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] godfreyhe commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink] Introduce planner rules to remove redundant shuffle and collation
Date Fri, 24 May 2019 07:39:55 GMT
godfreyhe commented on a change in pull request #8499: [FLINK-12575] [table-planner-blink]
Introduce planner rules to remove redundant shuffle and collation
URL: https://github.com/apache/flink/pull/8499#discussion_r287247271
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/batch/BatchExecJoinBase.scala
 ##########
 @@ -70,4 +76,150 @@ abstract class BatchExecJoinBase(
       "JoinConditionFunction",
       body)
   }
+
+  /**
+    * Try to satisfy hash distribution on Non-BroadcastJoin (including SortMergeJoin and
+    * Non-Broadcast HashJoin).
+    *
+    * @param requiredDistribution distribution requirement
+    * @return a Tuple including 3 element.
+    *         The first element is a flag which indicates whether the requirement can be
satisfied.
+    *         The second element is the distribution requirement of left child if the requirement
+    *         can be push down into join.
+    *         The third element is the distribution requirement of right child if the requirement
+    *         can be push down into join.
+    */
+  def satisfyHashDistributionOnNonBroadcastJoin(
+      requiredDistribution: FlinkRelDistribution)
+  : (Boolean, FlinkRelDistribution, FlinkRelDistribution) = {
 
 Review comment:
   the length exceeds the limitation when putting arguments and return type in one line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message