flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] dianfu commented on a change in pull request #8531: [FLINK-12440][python] Add all connector support align Java Table API.
Date Fri, 24 May 2019 08:44:36 GMT
dianfu commented on a change in pull request #8531: [FLINK-12440][python] Add all connector
support align Java Table API.
URL: https://github.com/apache/flink/pull/8531#discussion_r287261954
 
 

 ##########
 File path: flink-dist/src/main/flink-bin/bin/pyflink-gateway-server.sh
 ##########
 @@ -63,7 +63,7 @@ if [[ -n "$FLINK_TESTING" ]]; then
     else
       FLINK_TEST_CLASSPATH="$FLINK_TEST_CLASSPATH":"$testJarFile"
     fi
-  done < <(find "$FLINK_SOURCE_ROOT_DIR" ! -type d -name 'flink-*-tests.jar' -print0
| sort -z)
+  done < <(find "$FLINK_SOURCE_ROOT_DIR" ! -type d \( -name 'flink-*-tests.jar' -o
-path '*flink-connector-*-base/target/flink*.jar' \) -print0 | sort -z)
 
 Review comment:
   Specify flink-connector-kafka-base and flink-connector-elasticsearch-base explicitly as
flink-connector-*-base is not a good pattern and these two connectors just happen to have
this pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message