flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol opened a new pull request #8534: [FLINK-12614][yarn] Refactor test to not do assertions in @After methods
Date Fri, 24 May 2019 08:54:25 GMT
zentol opened a new pull request #8534: [FLINK-12614][yarn] Refactor test to not do assertions
in @After methods 
URL: https://github.com/apache/flink/pull/8534
 
 
   Refactors the YARN tests to only execute assertion within `@Test` methods. Previously,
assertions were also executed in `@After` methods, which tends to make the output on test
failure more difficult to read.
   
   I added a `runTests(Runnable)` method to the `YarnTestBase` which encapsulates the previous
`@After` assertions. All existing tests were modified to use this method instead.
   
   As a result the majority of changes in this PR are about indentation and exception signatures.
   
   Additionally,
   * the yarn client is shutdown in `@After`
   * an unused field was removed
   * a timeout was removed from 
   `YARNSessionCapacitySchedulerITCase#testVCoresAreSetCorrectlyAndJobManagerHostnameAreShownInWebInterfaceAndDynamicPropertiesAndYarnApplicationNameAndTaskManagerSlots`
so that the timeouts defined in test themselves cause the failure next time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message