flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment
Date Mon, 27 May 2019 08:56:02 GMT
sunjincheng121 commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements
in TableEnvironment
URL: https://github.com/apache/flink/pull/8474#discussion_r287656008
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -379,13 +383,97 @@ def create(cls, table_config):
 
         return t_env
 
+    def from_elements(self, elements, schema=None, verify_schema=True):
+        """
+        Creates a table from a collection of elements.
+
+        :param elements: The elements to create table from.
 
 Review comment:
   `The elements to create table from.` -> `The elements to create a table from.`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message