flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] JingsongLi commented on a change in pull request #8548: [FLINK-6962] [table] Add a create table SQL DDL
Date Mon, 27 May 2019 09:50:54 GMT
JingsongLi commented on a change in pull request #8548: [FLINK-6962] [table] Add a create table
SQL DDL
URL: https://github.com/apache/flink/pull/8548#discussion_r287719287
 
 

 ##########
 File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/SqlProperty.java
 ##########
 @@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.sql.parser;
+
+import org.apache.calcite.sql.SqlCall;
+import org.apache.calcite.sql.SqlIdentifier;
+import org.apache.calcite.sql.SqlKind;
+import org.apache.calcite.sql.SqlLiteral;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperator;
+import org.apache.calcite.sql.SqlSpecialOperator;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.util.ImmutableNullableList;
+import org.apache.calcite.util.NlsString;
+
+import java.util.List;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Properties of a DDL, consist of key value pairs.
+ */
+public class SqlProperty extends SqlCall {
+
+	/** Use this operator only if you don't have a better one. */
+	protected static final SqlOperator OPERATOR =
+		new SqlSpecialOperator("Property", SqlKind.OTHER);
+
+	private SqlIdentifier key;
+	private SqlNode value;
+
+	public SqlProperty(SqlIdentifier key, SqlNode value, SqlParserPos pos) {
+		super(pos);
+		this.key = requireNonNull(key, "Property key is missing");
+		this.value = requireNonNull(value, "Property value is missing");
+	}
+
+	public SqlIdentifier getKey() {
+		return key;
+	}
+
+	public SqlNode getValue() {
+		return value;
+	}
+
+	public String getKeyString() {
+		return key.toString();
+	}
+
+	public String getValueString() {
+		return ((NlsString) SqlLiteral.value(value)).getValue();
+	}
+
+	@Override
+	public SqlOperator getOperator() {
+		return OPERATOR;
+	}
+
+	@Override
+	public List<SqlNode> getOperandList() {
+		return ImmutableNullableList.of(key, value);
+	}
+
+	public void unparse(
 
 Review comment:
   Add `@Override` to all `unparse`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message