flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] klion26 commented on a change in pull request #8543: [FLINK-12101] Race condition when concurrently running uploaded jars via REST
Date Mon, 27 May 2019 12:41:15 GMT
klion26 commented on a change in pull request #8543: [FLINK-12101] Race condition when concurrently
running uploaded jars via REST
URL: https://github.com/apache/flink/pull/8543#discussion_r287775814
 
 

 ##########
 File path: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
 ##########
 @@ -1061,8 +1064,12 @@ private static String getDefaultName() {
 	 * @return The execution environment of the context in which the program is executed.
 	 */
 	public static ExecutionEnvironment getExecutionEnvironment() {
+
 		return contextEnvironmentFactory == null ?
-				createLocalEnvironment() : contextEnvironmentFactory.createExecutionEnvironment();
+				(contextEnvironmentFactoryThreadLocal.get() == null ?
 
 Review comment:
   Do we need to add `contextEnvironmentFactoryThreadLocal` check in the function `areExplicitEnvironmentsAllowed`(line
1284). I can't add a review there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message