flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout for shuffle API
Date Mon, 27 May 2019 14:31:26 GMT
zhijiangW commented on issue #8485: [FLINK-12555] Introduce an encapsulated metric group layout
for shuffle API
URL: https://github.com/apache/flink/pull/8485#issuecomment-496231763
 
 
   Thanks for the replies @zentol .
   
   But in this PR `parentGroup.addGroup("Network")` is called twice in `NetworkEnvironment#createResultPartitionWriters/InputGates`.
So we should change to create it still in task class and then pass it into `createResultPartitionWriters/InputGates`
separately?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message