flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhuzhurk commented on a change in pull request #8498: [FLINK-12413] [runtime] Implement ExecutionFailureHandler
Date Tue, 28 May 2019 02:15:13 GMT
zhuzhurk commented on a change in pull request #8498: [FLINK-12413] [runtime] Implement ExecutionFailureHandler
URL: https://github.com/apache/flink/pull/8498#discussion_r287909365
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailureHandlingResult.java
 ##########
 @@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph.failover.flip1;
+
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+
+import java.util.Collections;
+import java.util.Set;
+
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/**
+ * Result containing the tasks to restart upon a task failure.
+ * Also contains the reason if the failure is not recoverable(non-recoverable
+ * failure type or restarting suppressed by restart strategy).
+ */
+public class FailureHandlingResult {
+
+	/** Task vertices to restart to recover from the failure. */
+	private final Set<ExecutionVertexID> verticesToRestart;
+
+	/** Delay before the restarting can be conducted. */
+	private final long restartDelayMS;
+
+	/** Reason why the failure is not recoverable. */
+	private final Throwable error;
+
+	/**
+	 * Creates a result of a set of tasks to restart to recover from the failure.
+	 *
+	 * @param verticesToRestart containing task vertices to restart to recover from the failure
+	 * @param restartDelayMS indicate a delay before conducting the restart
+	 */
+	private FailureHandlingResult(Set<ExecutionVertexID> verticesToRestart, long restartDelayMS)
{
+		checkState(restartDelayMS >= 0);
+
+		this.verticesToRestart = Collections.unmodifiableSet(checkNotNull(verticesToRestart));
+		this.restartDelayMS = restartDelayMS;
+		this.error = null;
+	}
+
+	/**
+	 * Creates a result that the failure is not recoverable and no restarting should be conducted.
+	 *
+	 * @param error reason why the failure is not recoverable
+	 */
+	private FailureHandlingResult(Throwable error) {
+		this.verticesToRestart = null;
+		this.restartDelayMS = -1;
+		this.error = checkNotNull(error);
+	}
+
+	/**
+	 * Returns the tasks to restart.
+	 *
+	 * @return the tasks to restart
+	 */
+	public Set<ExecutionVertexID> getVerticesToRestart() {
+		if (canRestart()) {
+			return verticesToRestart;
+		} else {
+			throw new IllegalStateException("Cannot get vertices to restart when the restarting is
suppressed.");
+		}
+	}
+
+	/**
+	 * Returns the delay before the restarting.
+	 *
+	 * @return the delay before the restarting
+	 */
+	public long getRestartDelayMS() {
+		if (canRestart()) {
+			return restartDelayMS;
+		} else {
+			throw new IllegalStateException("Cannot get restart delay when the restarting is suppressed.");
+		}
+	}
+
+	/**
+	 * Returns whether the restarting can be conducted.
+	 *
+	 * @return whether the restarting can be conducted
+	 */
+	public boolean canRestart() {
+		return error == null;
+	}
+
+	/**
+	 * Returns reason why the restarting cannot be conducted.
+	 *
+	 * @return reason why the restarting cannot be conducted
+	 */
+	public Throwable getError() {
+		return error;
 
 Review comment:
   You are right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message