flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] gaoyunhaii opened a new pull request #8556: [FLINK-12171][Network] Do not limit the network buffer memory by heap size on the TM side
Date Tue, 28 May 2019 05:18:52 GMT
gaoyunhaii opened a new pull request #8556: [FLINK-12171][Network] Do not limit the network
buffer memory by heap size on the TM side
URL: https://github.com/apache/flink/pull/8556
 
 
   ## What is the purpose of the change
   
   This pull request fixes the bug that limits the network buffer size with the heap size
on the TM side. In fact, network buffer occupies a part of direct memory and is independent
with the heap.
   
   To fix this problem, The limitation on the TM side is removed. Although we may want to
compare the network memory size with the total memory size on the TM side, currently we can
only compute the total memory with heap + computed network memory and the computed total memory
should be always larger than the computed network memory.
   
   To remove the limitation, the max allowed memory used to check the network memory size
on TM side is changed to Long.MAX_VALUE. Another option is to move the checking to the caller
function on the RM side. however, it is not easy to achieve since the checking relies on the
configured values of MIN and MAX, and it is not accessible outside of the current function.
   
   ## Brief change log
     - *Change the maximum allow memory on TM side to Long.MAX_VALUE.*
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   
     - *Manually verified the change by running a cluster with two task managers for both
standalone and YARN mode, and test the configuration with heap = 3G/network = 2G and heap
= 5G/network = 2G*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message