flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StefanRRichter commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)
Date Tue, 28 May 2019 08:22:44 GMT
StefanRRichter commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer
callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r287716344
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1358,4 +1358,19 @@ public void actionsUnavailable() throws InterruptedException {
 			mailbox.putMail(actionUnavailableLetter);
 		}
 	}
+
+	private class TimerInvocationContext implements SystemProcessingTimeService.ScheduledCallbackExecutionContext
{
 
 Review comment:
   I am not sure if I like this approach of exposing the mailbox to the timer service. What
is the advantage over simply passing the `MailboxSender` interface into the SystemProcessingTimeService
and if needed a way to handle the async exception? I think that makes the code easier to follow
in comparison to callback ping-pong between stream task and timer service.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message