flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on issue #8557: [FLINK-12544][network] Fix the deadlock while releasing memory triggered by multiple threads in SpillableSubpartition
Date Tue, 28 May 2019 10:55:04 GMT
zhijiangW commented on issue #8557: [FLINK-12544][network] Fix the deadlock while releasing
memory triggered by multiple threads in SpillableSubpartition
URL: https://github.com/apache/flink/pull/8557#issuecomment-496467258
 
 
   @pnowojski , I thought of two ways for solving the deadlock issue:
   
   - One is making `owner.get().releaseMemory(1)` outside of `synchronized` in `LocalBufferPool#requestMemorySegment`.

   
   - Another is making the logic of `bufferConsumer.close()` during `SpillableSubpartition#spillFinishedBufferConsumers`
outside of `synchronized`.
   
   I take the first option in this PR and it seems more easier for fixing.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message