flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] azagrebin commented on a change in pull request #8320: [FLINK-12201][network, metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric
Date Tue, 28 May 2019 15:55:53 GMT
azagrebin commented on a change in pull request #8320: [FLINK-12201][network,metrics] Introduce
InputGateWithMetrics in Task to increment numBytesIn metric
URL: https://github.com/apache/flink/pull/8320#discussion_r288149888
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -382,19 +382,21 @@ public Task(
 			buffersGroup);
 
 		// consumed intermediate result partitions
-		this.inputGates = networkEnvironment.createInputGates(
+		SingleInputGate[] gates = networkEnvironment.createInputGates(
 
 Review comment:
   just a side comment: if we merge #8463 earlier then this can be already `InputGate[] this.inputGates
= ...` after rebase. Otherwise #8463 has to take it into account in its rebase :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message