flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #8541: [FLINK-9172][sql-client] Support catalogs in SQL-Client yaml config file
Date Tue, 28 May 2019 16:02:11 GMT
bowenli86 commented on a change in pull request #8541: [FLINK-9172][sql-client] Support catalogs
in SQL-Client yaml config file
URL: https://github.com/apache/flink/pull/8541#discussion_r288182100
 
 

 ##########
 File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
 ##########
 @@ -227,6 +241,12 @@ private static ClusterSpecification createClusterSpecification(CustomCommandLine
 		}
 	}
 
+	private Catalog createCatalog(String name, Map<String, String> catalogProperties,
ClassLoader classLoader) {
+		final CatalogFactory factory =
+			TableFactoryService.find(CatalogFactory.class, catalogProperties, classLoader);
 
 Review comment:
   I think it makes sense to rename the factory service and the factory interface itself to
something more generic. I'll discuss with Timo, and it should be of its own PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message