flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StefanRRichter commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)
Date Wed, 29 May 2019 07:44:18 GMT
StefanRRichter commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer
callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r288432083
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1358,4 +1358,19 @@ public void actionsUnavailable() throws InterruptedException {
 			mailbox.putMail(actionUnavailableLetter);
 		}
 	}
+
+	private class TimerInvocationContext implements SystemProcessingTimeService.ScheduledCallbackExecutionContext
{
+		@Override
+		public void invoke(ProcessingTimeCallback callback, long timestamp) throws InterruptedException
{
+			mailbox.putMail(() -> {
+				synchronized (getCheckpointLock()) {
 
 Review comment:
   For this PR, I think it is still needed. After all checkpoint related messages go through
the mailbox as well, I feel pretty sure that it is no longer needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message