flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] StefanRRichter commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)
Date Wed, 29 May 2019 07:59:31 GMT
StefanRRichter commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke timer
callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r288437652
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -1358,4 +1358,19 @@ public void actionsUnavailable() throws InterruptedException {
 			mailbox.putMail(actionUnavailableLetter);
 		}
 	}
+
+	private class TimerInvocationContext implements SystemProcessingTimeService.ScheduledCallbackExecutionContext
{
 
 Review comment:
   I think I cannot quiet follow your argument here. My problem with this solution from a
design point is, that there is code in the stream task that is talking about how the timer
service is wants to enqueue things into the mailbox. From a high-level view, do you agree
that this code should not belong there? Depending on what you think about this general concern,
there is also a solution that does all this inside the timer service, and the timer service
just knows the sender interface of the queue (and maybe the error handler). You could almost
move the code into the timer service, one the sender interface is a member there. Does that
solve the problem of why you did not want to do this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message