flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] azagrebin commented on a change in pull request #7549: [FLINK-11403][network] Introduce ResultPartitionWithConsumableNotifier in task for notifying consumable result partition
Date Wed, 29 May 2019 11:01:31 GMT
azagrebin commented on a change in pull request #7549: [FLINK-11403][network] Introduce ResultPartitionWithConsumableNotifier
in task for notifying consumable result partition
URL: https://github.com/apache/flink/pull/7549#discussion_r288505188
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
 ##########
 @@ -370,25 +370,21 @@ public Task(
 		final MetricGroup inputGroup = networkGroup.addGroup("Input");
 
 		// produced intermediate result partitions
-		ResultPartitionWriter[] partitionWriters = networkEnvironment.createResultPartitionWriters(
+		this.producedPartitions = new ResultPartitionWriter[resultPartitionDeploymentDescriptors.size()];
 
 Review comment:
   could we return `ResultPartitionWriter[]` from `createResultPartitionWriterWrapper`?
   `this.producedPartitions = createResultPartitionWriterWrapper(...);`
   I think this is more explicit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message