flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] pnowojski commented on a change in pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode
Date Wed, 29 May 2019 11:12:18 GMT
pnowojski commented on a change in pull request #8455: [FLINK-12284][Network,Metrics]Fix the
incorrect inputBufferUsage metric in credit-based network mode
URL: https://github.com/apache/flink/pull/8455#discussion_r288512179
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -439,6 +439,14 @@ public int getInitialCredit() {
 		return initialCredit;
 	}
 
+	public int unsafeGetExclusiveBufferUsed() {
 
 Review comment:
   `unsynchronized` instead of `unsafe` to match existing `unsynchronizedGetNumberOfQueuedBuffers`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message