flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment
Date Thu, 30 May 2019 09:03:43 GMT
sunjincheng121 commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements
in TableEnvironment
URL: https://github.com/apache/flink/pull/8474#discussion_r288909848
 
 

 ##########
 File path: docs/ops/cli.md
 ##########
 @@ -100,40 +100,40 @@ These examples about how to submit a job in CLI.
 
 -   Run Python Table program:
 
-        ./bin/flink run -py examples/python/table/batch/word_count.py -j <path/to/flink-table.jar>
+        ./bin/flink run -py examples/python/table/batch/word_count.py -C <path/to/flink-table.jar>
-C <path/to/flink-python-*-java-binding.jar>
 
 Review comment:
   Here is one concern: In this way, we should ask the user to keep the `path` consistent
with the cluster which is a bit inconvenient.  So, how about we deal with the `flink-python-*-java-binding.jar`
by flink framework.  and keep using `-j` for ` flink-table.jar`? because in future python
user may a `Python Table user` or a `Python dataStream` user. `flink-table.jar` not always
needed. What do you think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message