flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements in TableEnvironment
Date Thu, 30 May 2019 09:03:43 GMT
sunjincheng121 commented on a change in pull request #8474: [FLINK-12409][python] Adds from_elements
in TableEnvironment
URL: https://github.com/apache/flink/pull/8474#discussion_r288912410
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -379,13 +383,97 @@ def create(cls, table_config):
 
         return t_env
 
+    def from_elements(self, elements, schema=None, verify_schema=True):
+        """
+        Creates a table from a collection of elements.
+
+        :param elements: The elements to create table from.
+        :param schema: The schema of the table.
+        :param verify_schema: Whether to verify the elements against the schema.
 
 Review comment:
   Okay, coo...ol, if some data is gen by the program, and already sure do not need check.
 in this case, we can set verify_schema=False. 
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message