flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate
Date Tue, 01 Oct 2019 04:36:59 GMT
walterddr commented on issue #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource
does not change after applyPredicate
URL: https://github.com/apache/flink/pull/8468#issuecomment-536859787
 
 
   @KurtYoung sorry for the delay. I just implemented a way to safe check to prevent users
from utilizing a pushdown table source without overriding and explaining the predicator pushdown
in the `explainSource()` API. please kindly take a look when you have time.
   
   The throw exception might've been too much of a harsh term. I can change it to warning
and let the program pass if necessary, please let me know what do you think of this approach.
thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message