flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] walterddr commented on a change in pull request #8468: [FLINK-12399][table][table-planner] Fix FilterableTableSource does not change after applyPredicate
Date Tue, 01 Oct 2019 04:39:06 GMT
walterddr commented on a change in pull request #8468: [FLINK-12399][table][table-planner]
Fix FilterableTableSource does not change after applyPredicate
URL: https://github.com/apache/flink/pull/8468#discussion_r329875995
 
 

 ##########
 File path: flink-connectors/flink-orc/src/main/java/org/apache/flink/orc/OrcTableSource.java
 ##########
 @@ -213,7 +213,8 @@ public boolean isFilterPushedDown() {
 
 	@Override
 	public String explainSource() {
-		return "OrcFile[path=" + path + ", schema=" + orcSchema + ", filter=" + predicateString()
+ "]";
+		return "OrcFile[path=" + path + ", schema=" + orcSchema + ", filter=" + predicateString()
 
 Review comment:
   had to change this override since in fact the OrcTableSource does not explain the pushed
down predicate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message