flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] AHeise commented on a change in pull request #9717: [FLINK-14044] [runtime] Reducing synchronization in AsyncWaitOperator
Date Tue, 01 Oct 2019 07:56:22 GMT
AHeise commented on a change in pull request #9717: [FLINK-14044] [runtime] Reducing synchronization
in AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9717#discussion_r329922400
 
 

 ##########
 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java
 ##########
 @@ -100,6 +102,9 @@
 public class AsyncWaitOperatorTest extends TestLogger {
 	private static final long TIMEOUT = 1000L;
 
+	@Rule
+	public Timeout timeoutRule = new Timeout(10, TimeUnit.SECONDS);
 
 Review comment:
   These timeouts are just a safe-guard whenever we break stuff. All tests should always complete
without timeout. But it will be especially useful on Travis as we do not need to wait for
Travis to timeout to get a test result.
   
   Instead of just annotating the two tests that just failed (as we did in the past), I'd
annotate the whole suite with the junit rule, which makes it more readable. Imho @1u0 even
started with that rule and I just copied him ;).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message