flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] TisonKun commented on a change in pull request #9809: [FLINK-14282] Simplify DispatcherResourceManagerComponent hierarchy
Date Tue, 01 Oct 2019 10:13:16 GMT
TisonKun commented on a change in pull request #9809: [FLINK-14282] Simplify DispatcherResourceManagerComponent
hierarchy
URL: https://github.com/apache/flink/pull/9809#discussion_r329979407
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DefaultDispatcherResourceManagerComponentFactory.java
 ##########
 @@ -71,24 +71,23 @@
 /**
  * Abstract class which implements the creation of the {@link DispatcherResourceManagerComponent}
components.
  *
- * @param <T> type of the {@link DispatcherRunner}
  * @param <U> type of the {@link RestfulGateway} given to the {@link WebMonitorEndpoint}
  */
-public abstract class AbstractDispatcherResourceManagerComponentFactory<T extends DispatcherRunner,
U extends RestfulGateway> implements DispatcherResourceManagerComponentFactory {
+public class DefaultDispatcherResourceManagerComponentFactory<U extends RestfulGateway>
implements DispatcherResourceManagerComponentFactory {
 
 Review comment:
   Yes I agree we can have one dispatcher rm component and refactor the difference into helpers.
If it's on the way I'm ok with this temporary state. Otherwise if one should always instance
a job/session subclass it's better to mark as abstract.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message