flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] aljoscha commented on a change in pull request #9720: [FLINK-13025] Elasticsearch 7.x support
Date Mon, 14 Oct 2019 11:13:27 GMT
aljoscha commented on a change in pull request #9720: [FLINK-13025] Elasticsearch 7.x support
URL: https://github.com/apache/flink/pull/9720#discussion_r334431388
 
 

 ##########
 File path: flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
 ##########
 @@ -0,0 +1,45 @@
+flink-sql-connector-elasticsearch7
 
 Review comment:
   Hi, this is not correct, the list of `flink-shaded` dependencies has nothing to do with
the local shading in this connector. What I did now is to look at the output of `mvn clean
install` in the ES7 connector directory. It has a section about what is included and what
is not included. Based on this information I added some additional exclusions and I updated
the NOTICE file: https://github.com/aljoscha/flink/commit/b80c8b90f120cf5226eae98e88ba283973881c79.
I will apply this fix and then merge the PR.
   
   If you are more attentive to these subtle problems, like dependencies and the NOTICE file,
the PR review process could be a lot smoother.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message