flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on issue #9848: [FLINK-14332] [flink-metrics-signalfx] add flink-metrics-signalfx
Date Wed, 16 Oct 2019 14:14:25 GMT
zentol commented on issue #9848: [FLINK-14332] [flink-metrics-signalfx] add flink-metrics-signalfx
URL: https://github.com/apache/flink/pull/9848#issuecomment-542722336
 
 
   Just a few drive-by notes:
   
   1. there should be a discussion on the ML as to whether accept more reporters; we already
maintain quite a few and have to start thinking about maintainability. Why could this not
be maintained outside of Flink?
   2. Wouldn't this be a lot easier to implement if we simply bumped dropwizard? Our current
version is fairly old anyway.
   3. If 2) doesn't work, then the reporter should be implemented using the new factory approach;
see the JMXReporter as an example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message