flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] GJL commented on a change in pull request #9832: [FLINK-11843] Bind lifespan of Dispatcher to leader session
Date Wed, 16 Oct 2019 15:16:50 GMT
GJL commented on a change in pull request #9832: [FLINK-11843] Bind lifespan of Dispatcher
to leader session
URL: https://github.com/apache/flink/pull/9832#discussion_r335493271
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DispatcherResourceManagerComponent.java
 ##########
 @@ -130,6 +135,8 @@ public DispatcherRunner getDispatcherRunner() {
 	}
 
 	private CompletableFuture<Void> closeAsyncInternal() {
+		LOG.info("Closing components of {}.", getClass().getSimpleName());
 
 Review comment:
   I find it unnecessary to log the class name explicitly. There are a couple occurrences
of this pattern in this PR. The logger name already is the class name. Moreover, the class
name of the caller can be [configured as a pattern](http://logback.qos.ch/manual/layouts.html#class).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message