azagrebin commented on a change in pull request #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec
fields with the new TaskExecutor memory setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r335500699
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/operators/ResourceSpec.java
##########
@@ -229,15 +246,14 @@ public boolean isValid() {
*/
public boolean lessThanOrEqual(@Nonnull ResourceSpec other) {
if (this == UNKNOWN || other == UNKNOWN) {
- throw new IllegalArgumentException("UNKNOWN ResourceSpec cannot be numerically compared.");
+ throw new IllegalArgumentException("UNKNOWN ResourceSpecs cannot be numerically compared.");
Review comment:
better to move this change to the previous commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|