flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #9931: [FLINK-14441][Table-Common] Fix ValueLiteralExpression#getValueAs when valueClass is Period.class
Date Mon, 21 Oct 2019 06:18:32 GMT
wuchong commented on a change in pull request #9931: [FLINK-14441][Table-Common] Fix ValueLiteralExpression#getValueAs
when valueClass is Period.class
URL: https://github.com/apache/flink/pull/9931#discussion_r336850720
 
 

 ##########
 File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/expressions/ExpressionTest.java
 ##########
 @@ -160,6 +161,16 @@ public void testSymbolValueLiteralExtraction() {
 				.orElseThrow(AssertionError::new));
 	}
 
+	@Test
+	public void testPeriodlValueLiteralExtraction() {
 
 Review comment:
   ```suggestion
   	public void testPeriodValueLiteralExtraction() {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message