azagrebin commented on a change in pull request #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec
fields with the new TaskExecutor memory setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r337401369
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java
##########
@@ -292,7 +349,15 @@ public boolean isMatching(ResourceProfile required) {
@Override
public int compareTo(@Nonnull ResourceProfile other) {
- int cmp = Integer.compare(this.getMemoryInMB(), other.getMemoryInMB());
+ if (this == other) {
+ return 0;
+ } else if (this == UNKNOWN) {
Review comment:
Are there cases where we have to compare with `UNKNOWN`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|