flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] azagrebin commented on a change in pull request #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec fields with the new TaskExecutor memory setups.
Date Tue, 22 Oct 2019 09:44:44 GMT
azagrebin commented on a change in pull request #9910: [FLINK-14405][runtime] Align ResourceProfile/ResourceSpec
fields with the new TaskExecutor memory setups.
URL: https://github.com/apache/flink/pull/9910#discussion_r337112507
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImplTest.java
 ##########
 @@ -1038,7 +1038,7 @@ public void testReportAllocatedSlot() throws Exception {
 			final SlotRequest slotRequest = new SlotRequest(
 				new JobID(),
 				allocationId,
-				ResourceProfile.UNKNOWN,
+				ResourceProfile.ANY,
 
 Review comment:
   `UNKNOWN` was correct for the request here, right?
   This probably also does not matter for all these tests, this is why it is hard to catch
the misuses :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message