flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lirui-apache commented on a change in pull request #9988: [FLINK-14418][hive] Create HiveModule to provide Hive built-in functions
Date Thu, 31 Oct 2019 03:12:08 GMT
lirui-apache commented on a change in pull request #9988: [FLINK-14418][hive] Create HiveModule
to provide Hive built-in functions
URL: https://github.com/apache/flink/pull/9988#discussion_r340943437
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/functions/hive/HiveGenericUDAFTest.java
 ##########
 @@ -130,7 +131,7 @@ public void testUDAFCount() throws Exception {
 	private static HiveGenericUDAF init(Class hiveUdfClass, Object[] constantArgs, DataType[]
argTypes) throws Exception {
 		HiveFunctionWrapper<GenericUDAFResolver2> wrapper = new HiveFunctionWrapper(hiveUdfClass.getName());
 
-		HiveGenericUDAF udf = new HiveGenericUDAF(wrapper, HiveShimLoader.getHiveVersion());
+		HiveGenericUDAF udf = new HiveGenericUDAF(wrapper, HiveShimLoader.loadHiveShim(HiveVersionInfo.getVersion()));
 
 Review comment:
   HiveShimLoader also has a getHiveVersion interface

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message