flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lirui-apache commented on a change in pull request #9988: [FLINK-14418][hive] Create HiveModule to provide Hive built-in functions
Date Thu, 31 Oct 2019 03:17:03 GMT
lirui-apache commented on a change in pull request #9988: [FLINK-14418][hive] Create HiveModule
to provide Hive built-in functions
URL: https://github.com/apache/flink/pull/9988#discussion_r340945230
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveFunctionDefinitionFactory.java
 ##########
 @@ -114,16 +109,16 @@ public FunctionDefinition createFunctionDefinition(String name, CatalogFunction
 
 			if (GenericUDAFResolver2.class.isAssignableFrom(clazz)) {
 				LOG.info(
-					"Transforming Hive function '{}' into a HiveGenericUDAF with no UDAF bridging and Hive
version %s",
-					name, hiveVersion);
+					"Transforming Hive function '{}' into a HiveGenericUDAF with no UDAF bridging",
+					name, hiveShim);
 
 Review comment:
   why is hiveShim needed here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message